Adding support for AWS Secrets Manager #955
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eature/AWSSecretManager
…eature/AWSSecretManager
AWS Secrets Manager implementation for KeyVault added
…o feature/AWSSecretManager � Conflicts: � cli/cli-api/src/test/java/com/quorum/tessera/cli/keypassresolver/CliKeyPasswordResolverTest.java � cli/config-cli/src/main/java/com/quorum/tessera/config/cli/parsers/KeyGenerationParser.java � cli/config-cli/src/test/java/com/quorum/tessera/config/cli/OverrideUtilTest.java � cli/config-cli/src/test/java/com/quorum/tessera/config/cli/parsers/KeyGenerationParserTest.java � config-migration/src/test/java/com/quorum/tessera/config/migration/test/FixtureUtil.java � config/src/main/java/com/quorum/tessera/config/JaxbConfigFactory.java � config/src/main/java/com/quorum/tessera/config/KeyConfiguration.java � config/src/main/java/com/quorum/tessera/config/adapters/KeyDataAdapter.java � config/src/test/java/com/quorum/tessera/config/adapters/KeyDataAdapterTest.java � key-generation/src/main/java/com/quorum/tessera/key/generation/DefaultKeyGeneratorFactory.java � key-generation/src/test/java/com/quorum/tessera/key/generation/KeyGeneratorFactoryTest.java
…Pair.java Co-Authored-By: chris-j-h <39617426+chris-j-h@users.noreply.github.com>
…Pair.java Co-Authored-By: chris-j-h <39617426+chris-j-h@users.noreply.github.com>
…hub.com/vgeorgescu/tessera into feature/AWSSecretManager � Conflicts: � tessera-grpc/grpc-service/pom.xml
Excluding the dependency would introduce issues for users running acceptance tests with the slim jar when not also including the aws shaded jar on the classpath
The updated validation checks only that a scheme has been provided. This makes testing simpler and should be sufficient for now.
# Conflicts: # cli/config-cli/src/main/java/com/quorum/tessera/config/cli/parsers/KeyGenerationParser.java # cli/config-cli/src/test/java/com/quorum/tessera/config/cli/parsers/KeyGenerationParserTest.java # config/src/main/java/com/quorum/tessera/config/KeyConfiguration.java # pom.xml
chris-j-h
requested review from
melowe,
namtruong,
nicolae-leonte-go,
prd-fox and
SatpalSandhu61
as code owners
Krish1979
previously approved these changes
Jan 7, 2020
Codecov Report
@@ Coverage Diff @@
## master #955 +/- ##
===========================================
- Coverage 99.31% 99.3% -0.02%
- Complexity 2088 2146 +58
===========================================
Files 320 328 +8
Lines 5709 5871 +162
Branches 328 345 +17
===========================================
+ Hits 5670 5830 +160
Misses 5 5
- Partials 34 36 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds supports for AWS Secrets Manager as a way to store and retrieve Tessera key pairs.
Replaces #947. Differences to #947 include: