Adding support for AWS Secrets Manager #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eature/AWSSecretManager
…eature/AWSSecretManager
…gerDone AWS Secrets Manager implementation for KeyVault added
…o feature/AWSSecretManager � Conflicts: � cli/cli-api/src/test/java/com/quorum/tessera/cli/keypassresolver/CliKeyPasswordResolverTest.java � cli/config-cli/src/main/java/com/quorum/tessera/config/cli/parsers/KeyGenerationParser.java � cli/config-cli/src/test/java/com/quorum/tessera/config/cli/OverrideUtilTest.java � cli/config-cli/src/test/java/com/quorum/tessera/config/cli/parsers/KeyGenerationParserTest.java � config-migration/src/test/java/com/quorum/tessera/config/migration/test/FixtureUtil.java � config/src/main/java/com/quorum/tessera/config/JaxbConfigFactory.java � config/src/main/java/com/quorum/tessera/config/KeyConfiguration.java � config/src/main/java/com/quorum/tessera/config/adapters/KeyDataAdapter.java � config/src/test/java/com/quorum/tessera/config/adapters/KeyDataAdapterTest.java � key-generation/src/main/java/com/quorum/tessera/key/generation/DefaultKeyGeneratorFactory.java � key-generation/src/test/java/com/quorum/tessera/key/generation/KeyGeneratorFactoryTest.java
…Pair.java Co-Authored-By: chris-j-h <39617426+chris-j-h@users.noreply.github.com>
…Pair.java Co-Authored-By: chris-j-h <39617426+chris-j-h@users.noreply.github.com>
…hub.com/vgeorgescu/tessera into feature/AWSSecretManager � Conflicts: � tessera-grpc/grpc-service/pom.xml
Emi14
requested review from
chris-j-h,
melowe,
namtruong and
nicolae-leonte-go
as code owners
Krish1979
previously approved these changes
Dec 23, 2019
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
I've made some changes to the key vault config to facilitate the addition of new implementations by having simple properties associated with the value impl. I'll try and the changes required for AWS support following this. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Resolving the merge conflicts and making the necessary changes to work with our updated master branch have been made and raised as a separate PR. Thanks for making this change, this PR will be closed in favour of #955. |
# Conflicts: # cli/config-cli/src/main/java/com/quorum/tessera/config/cli/KeyGenCommand.java # cli/config-cli/src/test/java/com/quorum/tessera/config/cli/KeyGenCommandTest.java # config/src/main/java/com/quorum/tessera/config/DefaultKeyVaultConfig.java # config/src/main/java/com/quorum/tessera/config/KeyConfiguration.java # config/src/main/java/com/quorum/tessera/config/KeyVaultConfigConverter.java # config/src/main/java/com/quorum/tessera/config/constraints/KeyVaultConfigValidator.java # config/src/main/java/com/quorum/tessera/config/constraints/ValidKeyVaultConfig.java # config/src/test/java/com/quorum/tessera/config/KeyConfigurationTest.java # config/src/test/java/com/quorum/tessera/config/KeyVaultConfigConverterTest.java # config/src/test/java/com/quorum/tessera/config/constraints/KeyVaultConfigValidatorTest.java # pom.xml
Codecov Report
@@ Coverage Diff @@
## master #947 +/- ##
===========================================
- Coverage 99.31% 99.3% -0.02%
- Complexity 2088 2146 +58
===========================================
Files 320 328 +8
Lines 5709 5871 +162
Branches 328 345 +17
===========================================
+ Hits 5670 5830 +160
Misses 5 5
- Partials 34 36 +2
Continue to review full report at Codecov.
|
Krish1979
approved these changes
Jan 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quorum documentation PR - Consensys/quorum#919