ContainerSSH Metrics are not Prometheus Compatible #537
Labels
bug
Something isn't working
Milestone
Comments
|
I see this was fixed in libcontainerssh here ContainerSSH/libcontainerssh#93 Is there an ETA on when a new version of ContainerSSH will be released with this fix? |
|
Hello @ChristopherJMiller thank you for this bug report. The current plan is a release early Q1 next year. |
|
Closing this as it was fixed with the release of 0.5. |
tsipinakis
added a commit
to tsipinakis/ContainerSSH
that referenced
this issue
May 5, 2024
) * Fix authz webhook not being called Signed-off-by: Nikos Tsipinakis <nikos@tsipinakis.com> * Add codecov support for coverage reporting Signed-off-by: Nikos Tsipinakis <nikos@tsipinakis.com> * Unify authz configuration with the other methods Authz webhook configuration will now be placed under the 'webhook' key to be in line with the other authentication methods. Signed-off-by: Nikos Tsipinakis <nikos@tsipinakis.com> * Add authz support to testauthconfig server Signed-off-by: Nikos Tsipinakis <nikos@tsipinakis.com> * Test authz in integration Signed-off-by: Nikos Tsipinakis <nikos@tsipinakis.com> --------- Signed-off-by: Nikos Tsipinakis <nikos@tsipinakis.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Attempting to scrape the metrics endpoint into prometheus fails with the error:
In determining why I was receiving this error, I found that according to the metrics and labels documentation for prometheus, all metrics must end with a plural suffix of it's unit (which looks to be set by the comment to be "requests").
To Reproduce
Expected behavior
Scrapes successfully
Version
0.4.1
The text was updated successfully, but these errors were encountered: