Rename prometheus metrics to match units #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, but will need a documentation change too. Holding this until I figured out what needs changing in the docs. |
janosdebugs
suggested changes
Mar 9, 2022
There was a problem hiding this comment.
@tsipinakis this breaks backwards compatibility. Can you confirm that the previous version doesn't work in Prometheus? Otherwise we'd temporarily need to add new metrics alongside the old ones.
|
I can confirm it doesn't work with Prometheus 2.33.4 |
janosdebugs
approved these changes
Mar 9, 2022
janosdebugs
force-pushed
the
prometheus_naming
branch
from
cbcd7c7
to
018f6a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the change you are making
Fixes #12
Are you the owner of the code you are sending in, or do you have permission of the owner?
Yes
The code will be published under the MIT-0 license. Have you read and understood this license?
Yes