Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use isinstance instead of is or == to test for object type compatability #209

Open
jeremymanning opened this issue May 16, 2018 · 0 comments
Open

use isinstance instead of is or == to test for object type compatability #209

jeremymanning opened this issue May 16, 2018 · 0 comments

Comments

@jeremymanning
Copy link
Member

Our current type checking machinery is not robust to sub-classes. We should instead use isinstance(x, desired_type) for these checks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeremymanning