Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenLORIS dataloader #223

Merged
merged 2 commits into from
Dec 18, 2020
Merged

Add OpenLORIS dataloader #223

merged 2 commits into from
Dec 18, 2020

Conversation

ffeng1996
Copy link
Collaborator

@ffeng1996 ffeng1996 commented Dec 15, 2020

Hi,

The added please find the OpenLORIS data-loader.

The current loader is based on Google driver API, thus we add one package downloader script inside the environment-dev.yml file.

After consulting with Dr. Rosa Chan (the corresponding author of the OpenLORIS paper), we plan to order a server to store the dataset. I will update the corresponding downloading scripts when the server is ready.

Thanks for taking the time.

Eric

@vlomonaco
Copy link
Member

@lrzpellegrini what was the trick to download from gdrive without an additional package?

@vlomonaco
Copy link
Member

vlomonaco commented Dec 17, 2020

@ffeng1996 I don't quite understand: does the download work with the script as it is?

@ffeng1996
Copy link
Collaborator Author

@vlomonaco Yes, the download module is specified from Line 74-88 in avalanche/benchmarks/datasets/openloris/openloris_data.py. Here we utilized the GoogleDriveDownloader package to download the data from Google Drive. So I added the package name inside the environment-dev.yml file.

@ffeng1996
Copy link
Collaborator Author

@vlomonaco Yes, the download module is specified from Line 74-88 in avalanche/benchmarks/datasets/openloris/openloris_data.py. Here we utilized the GoogleDriveDownloader package to download the data from Google Drive. So I added the package name inside the environment-dev.yml file.

When the server is ready, I will remove this package and make it to download it directly from the server.

@vlomonaco
Copy link
Member

Ok, thanks! I'm merging it and I'll open an issue in case of doubts or problems!

@vlomonaco vlomonaco merged commit 729a4af into ContinualAI:master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants