Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phoebus Integration #2437

Open
shroffk opened this issue Jun 5, 2018 · 3 comments
Open

Phoebus Integration #2437

shroffk opened this issue Jun 5, 2018 · 3 comments
Assignees
@shroffk
Milestone
4.6.0 - testing (...

Comments

@shroffk
Copy link
Member

shroffk commented Jun 5, 2018

Create a plugin which provides a service which allows for the launching of cs-studio/phoebus.
@shroffk shroffk self-assigned this Jun 5, 2018
@shroffk
Copy link
Member Author

shroffk commented Jun 5, 2018

@kasemir
I have two options when it comes to including launch actions for various phoebus applications from cs-studio.

Option 1.
Add the launch action in the associated application plugin itself...i.e in the o.c.diag.probe
This would add a dependency to the o.c.phoebus.integration plugin and would need additional preferences to allow users to enable/disable including phoebus actions.

Option 2.
Create a new stand alone plugin which registers the actions.
This would mean that the app launch action would not be in the same plugin with the old cs-studio applications...but it would be easy for people to control weather to include these actions in their product.

Which option should I add...I am leaning towards Option2. since it would be the lease disruptive although not the nicest way.

@kasemir
Copy link
Contributor

kasemir commented Jun 5, 2018

Yes, 2, for the reasons you mention.
That way, you can decide if you want to include 'probe' or 'launch-probe-in-phoebus', 'PV Tree' or 'launch-PV-Tree-in-phoebus', 'XXX' or 'launch-XXX-in-phoebus' in your site-specific product.
I also see value in not having to change the existing XXX code at all for this purpose.

shroffk added a commit to shroffk/cs-studio that referenced this issue Jun 5, 2018
@shroffk
ControlSystemStudio#2437 creating the first phoebus integration modul…
7a4381e 
…es and services
shroffk added a commit to shroffk/cs-studio that referenced this issue Jun 5, 2018
@shroffk
ControlSystemStudio#2437 basic javadoc's for phoebusLauncherService
4edb079
shroffk added a commit to shroffk/cs-studio that referenced this issue Jun 5, 2018
@shroffk
ControlSystemStudio#2437 2 example commands for launching phoebus app…
643f78a 
…lications.
shroffk added a commit to shroffk/cs-studio that referenced this issue Jun 8, 2018
@shroffk
ControlSystemStudio#2437 adding email and channel table
d7d3633
@berryma4 berryma4 added this to the 4.6.0 - testing (master) milestone Jun 12, 2018
berryma4 added a commit that referenced this issue Aug 3, 2018
@berryma4
Merge pull request #2439 from shroffk/Issue_2437
695baf4 
Issue #2437
@willrogers willrogers mentioned this issue Aug 9, 2018
Merged
shroffk added a commit to shroffk/cs-studio that referenced this issue Oct 30, 2018
@shroffk
ControlSystemStudio#2437 creating channel finder application integrat…
a89b1d5 
…ion with phoebus
shroffk added a commit to shroffk/cs-studio that referenced this issue Oct 30, 2018
@shroffk
ControlSystemStudio#2437 removing channel finder integration from the…
6b48712 
… common plugin
shroffk added a commit that referenced this issue Oct 30, 2018
@shroffk
#2437 creating channel finder application integration with phoebus
0a50e84
shroffk added a commit that referenced this issue Oct 30, 2018
@shroffk
#2437 removing channel finder integration from the common plugin
c7cae7e
shroffk added a commit that referenced this issue Oct 30, 2018
@shroffk
#2437 fix checkstyle errors
cf90d2a
berryma4 added a commit that referenced this issue Oct 31, 2018
@berryma4
Merge pull request #2537 from ControlSystemStudio/Issue_2437
a6e68e3 
Issue #2437
@shroffk
Copy link
Member Author

shroffk commented Oct 31, 2018 •
edited
Loading

Integrate (menu actions)

  • probe
  • databrowser
  • displaybuilder
  • alarm applications
  • channel applications
  • logbook applications

Integrate (context menu actions)

  • probe
  • databrowser
  • displaybuilder
  • alarm applications
  • channel applications
  • logbook applications

shroffk added a commit that referenced this issue Dec 12, 2018
@shroffk
#2437 adding example editor which open files in phoebus
41fe98a
shroffk added a commit that referenced this issue Dec 12, 2018
@shroffk
#2437 adding example editor which open files in phoebus (fix checkstyle)
aa541fc
berryma4 added a commit that referenced this issue Apr 10, 2019
@berryma4
Merge pull request #2552 from ControlSystemStudio/Issue_2437
8eb26da 
#2437 adding example editor which open files in phoebus
shroffk added a commit that referenced this issue May 3, 2019
@shroffk
#2437 adding action in BOY to open resources in phoebus
433ab72
shroffk added a commit that referenced this issue May 3, 2019
@shroffk
#2437 phoebus BOY actions parses and forwards macros
51cb628
shroffk added a commit that referenced this issue May 6, 2019
@shroffk
#2437 phoebus BOY action fix style
b8c75d0
shroffk added a commit that referenced this issue May 8, 2019
@shroffk
#2437 phoebus integration, set BOY integration default to false
e08eb5a
berryma4 added a commit that referenced this issue May 8, 2019
@berryma4
Merge pull request #2590 from ControlSystemStudio/Issue_2437
9d8e7b2 
#2437 adding action in BOY to open resources in phoebus
shroffk added a commit that referenced this issue Jul 30, 2019
@shroffk
#2437 preferences for using site specific system phoebus & launcher
32a0422
shroffk added a commit that referenced this issue Jul 30, 2019
@shroffk
#2437 split phoebus probe integration into stand alone plugin
6cc7bf3
shroffk added a commit that referenced this issue Jul 30, 2019
@shroffk
#2437 split phoebus probe integration into stand alone plugin
46f4fea
shroffk added a commit that referenced this issue Jul 30, 2019
@shroffk
#2437 split phoebus pvtable integration into stand alone plugin
7f33fa8
shroffk added a commit that referenced this issue Jul 31, 2019
@shroffk
#2437 split phoebus pvtable integration into stand alone plugin
b293bd5
shroffk added a commit that referenced this issue Jul 31, 2019
@shroffk
#2437 split phoebus pvtree integration into stand alone plugin
c973583
shroffk added a commit that referenced this issue Jul 31, 2019
@shroffk
#2437 split phoebus opi integration into stand alone plugin
bcd6f8a
shroffk added a commit that referenced this issue Jul 31, 2019
@shroffk
#2437 add new modules to phoebus-plugins and cleanup
563b902
shroffk added a commit that referenced this issue Jul 31, 2019
@shroffk
#2437 split the core integration plugin and all other into 2 features
e7da4ec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shroffk shroffk

Labels
None yet
Projects
None yet
Milestone
4.6.0 - testing (master)
Development

No branches or pull requests
3 participants
@berryma4 @kasemir @shroffk