Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack overflow when using custom playIcon #740

Closed
madeleineostoja opened this issue Nov 8, 2019 · 3 comments
Closed

Stack overflow when using custom playIcon #740

madeleineostoja opened this issue Nov 8, 2019 · 3 comments

Comments

@madeleineostoja
Copy link

madeleineostoja commented Nov 8, 2019

Current Behavior

When using a custom play icon with the new playIcon prop, clicking the icon throws an stack overflow error with recursive calls to isEqual(object) here https://github.com/CookPete/react-player/blob/master/src/utils.js#L165 in latest Chrome.

Expected Behavior

Clicking the custom play icon should have the same behavior as the default play icon, and not blow up my app

Steps to Reproduce

  1. Provide custom play icon
  2. Click it
@i7N3
Copy link

i7N3 commented Nov 11, 2019

Until the bug is fixed, you can customize the icon by redefining the styles.
classes: .react-player__shadow {} and .react-player__play-icon {}

@cookpete
Copy link
Owner

Hopefully sorted in v1.14.1 👍

@sumit151199
Copy link

Hey @seaneking @cookpete ,
please send me sample code how you set custom playIcon

albanqoku added a commit to albanqoku/react-player that referenced this issue Feb 24, 2021
Webmaster1116 added a commit to Webmaster1116/video-player that referenced this issue May 20, 2021
webmiraclepro added a commit to webmiraclepro/video-player that referenced this issue Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants