-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2.2 #10
Merged
Merged
Release 2.2 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now, if the player is teleporting into a config-defined blocked-region, we no longer notify the player directly, simply log into console that entity checks were not carried out since it was a blocked region.
2.1 had incorrectly classified conditions (1) an entity type was allowed in config, but not leashed by the player (2) was a tameable entity not belonging to player (3) tamed entity was sitting (and couldn't be teleported) as teleport-fails. These are more of cases that the plugin prevents teleporting due to a mis-matched rule. Splitting these should reduce spam of message implying a teleport fail occurred. Should fix #5.
Bumping compiler to OAT-2.2
Adding .idea files to ignore
Adding a moment of invulnerability for the entity so it doesn't take damage in the immediate teleport. Restores it to the state before (in case entity was already invulnerable, we don't want to make it vulnerable)
Moves the "Hooray" notification about plugin being up to date to the console rather than annoying the player. Fixes #9
Integer valueOf returned Integer type, while comparison was of type int. Changed to parseInt to remove unnecessary casting.
Plugin will now use common message send methods rather than reusing same code in listeners class
Adding a method that parses the teleport event and replaces location variables so this code isn't reused in multiple places.
Moving this block of code to its own method.
Clearing up notes
In versions below 1.19.3, leaving a vehicle triggered an unknown teleport cause. If you are on versions below 1.19.3, setting this config value to FALSE should help catch this issue and remove the unnecessary player notification about an entity being left behind. In versions greater than 1.19.3, a DISMOUNT cause was added due to this report. This config value can safely be ignored on versions >= 1.19.3. Fixes #7
Listener now adds checks for unknown/dismount teleports, has world group checking using plugin common methods, etc.
Fixing typo in config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additions
Deletions
Modifications