Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.2 #10

Merged
merged 20 commits into from
Feb 2, 2023
Merged

Release 2.2 #10

merged 20 commits into from
Feb 2, 2023

Conversation

CoolLord22
Copy link
Owner

Additions

  • Added new message to player for an entity being left behind. Distinguishes this from the message sent when an entity wasn't teleported due to an error. 4b440e2 c1c09d5
  • Adds a short delay of invulnerability to the entity being teleported to prevent unintended damage. 22fdb61
  • Added new flag to ignore unknown teleport causes. IMPORTANT This may help solve vehicle dismount left messages on versions < 1.19.3. In version 1.19.3 and above, a dismount event was added to teleport cause, so this can safely be ignored. Fixes Ignore teleport event for vehicle exit #7 6483295

Deletions

  • Removed 1.18 dependency as 1.19 should be backwards compliant
  • Removed player update notifications when plugin is already up-to-date. Only logged in console now on startup. Closes Up-to-date message #9 89f7c9a
  • Removed unused code. 8194f45

Modifications

  • Bumping plugin version to 2.2. 0181d5b
  • Updating dependencies to latest snapshot. 0a45160 e1d8a34
  • Removed player messenger for entities not teleported due to a blocked WG region. Logged in console instead now. c0c2c4e
  • Created new checks for entity teleportation. Fixes some logic issues that previously existed with players getting error messages when they should not have. Closes 'Entity could not teleport' message regardless of mob's leash status #5 6dee8ec
  • Fixing some .gitignore files. 430cd66
  • Fixing a typo in update checker. 2709f49
  • Using parseInt instead of valueOf to prevent unnecessary type casting. 383146b
  • Moved player message to be handled by OATCommon methods. 6edaad4 b989c47
  • Updated config to clean up some notes and typos. c82a092 68adb8b
  • Code cleanup for teleport listener and moving some code to common methods. 1553160

Now, if the player is teleporting into a config-defined blocked-region, we no longer notify the player directly, simply log into console that entity checks were not carried out since it was a blocked region.
2.1 had incorrectly classified conditions (1) an entity type was allowed in config, but not leashed by the player (2) was a tameable entity not belonging to player (3) tamed entity was sitting (and couldn't be teleported) as teleport-fails. These are more of cases that the plugin prevents teleporting due to a mis-matched rule. Splitting these should reduce spam of message implying a teleport fail occurred. Should fix #5.
Bumping compiler to OAT-2.2
Adding .idea files to ignore
Adding a moment of invulnerability for the entity so it doesn't take damage in the immediate teleport. Restores it to the state before (in case entity was already invulnerable, we don't want to make it vulnerable)
Moves the "Hooray" notification about plugin being up to date to the console rather than annoying the player. Fixes #9
Integer valueOf returned Integer type, while comparison was of type int. Changed to parseInt to remove unnecessary casting.
Plugin will now use common message send methods rather than reusing same code in listeners class
Adding a method that parses the teleport event and replaces location variables so this code isn't reused in multiple places.
Moving this block of code to its own method.
Clearing up notes
In versions below 1.19.3, leaving a vehicle triggered an unknown teleport cause. If you are on versions below 1.19.3, setting this config value to FALSE should help catch this issue and remove the unnecessary player notification about an entity being left behind. In versions greater than 1.19.3, a DISMOUNT cause was added due to this report. This config value can safely be ignored on versions >= 1.19.3. Fixes #7
Listener now adds checks for unknown/dismount teleports, has world group checking using plugin common methods, etc.
Fixing typo in config
@CoolLord22 CoolLord22 self-assigned this Feb 2, 2023
@CoolLord22 CoolLord22 merged commit 17c1759 into master Feb 2, 2023
@CoolLord22 CoolLord22 deleted the 2.2 branch February 2, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant