Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Up-to-date message #9

Closed
SimplyJeevS opened this issue Feb 1, 2023 · 4 comments · Fixed by #10
Closed

Up-to-date message #9

SimplyJeevS opened this issue Feb 1, 2023 · 4 comments · Fixed by #10
Assignees
Labels
Enhancement New feature or request Resolved Issue/question has been addressed

Comments

@SimplyJeevS
Copy link

SimplyJeevS commented Feb 1, 2023

The up to date message is quite useless and a soar on peoples eyes in my opinion.
It would be way better to just let user know whenever there is an update. This would be a simple as adding an if clause to check if you have updated the version number on GitHub or spigot.
If you really wanne keep the up-to-date message around i would suggest putting it in console right after the plugin load!
Apart from that an amazing plugin, hope you will consider it.

@CoolLord22 CoolLord22 added the Enhancement New feature or request label Feb 1, 2023
@CoolLord22 CoolLord22 self-assigned this Feb 1, 2023
CoolLord22 added a commit that referenced this issue Feb 1, 2023
Moves the "Hooray" notification about plugin being up to date to the console rather than annoying the player. Fixes #9
@CoolLord22 CoolLord22 added the Resolved Issue/question has been addressed label Feb 1, 2023
@CoolLord22
Copy link
Owner

CoolLord22 commented Feb 1, 2023

See above. I think originally that was the plan, to only notify console, but I put it in the wrong if check for when player was null. Thanks for the suggestion! Will be implemented in 2.2 :)

@SimplyJeevS
Copy link
Author

No worries glad i could suggest it and thanks for being so on the ball!

@CoolLord22
Copy link
Owner

(Gonna keep this open until it gets merged into main branch)

@CoolLord22 CoolLord22 reopened this Feb 2, 2023
@CoolLord22 CoolLord22 mentioned this issue Feb 2, 2023
@SimplyJeevS
Copy link
Author

Thanks again for getting on-top of this so quickly! Left you a banger of a review on spigot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Resolved Issue/question has been addressed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants