-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Up-to-date message #9
Comments
Moves the "Hooray" notification about plugin being up to date to the console rather than annoying the player. Fixes #9
See above. I think originally that was the plan, to only notify console, but I put it in the wrong if check for when player was null. Thanks for the suggestion! Will be implemented in 2.2 :) |
No worries glad i could suggest it and thanks for being so on the ball! |
(Gonna keep this open until it gets merged into main branch) |
Thanks again for getting on-top of this so quickly! Left you a banger of a review on spigot! |
The up to date message is quite useless and a soar on peoples eyes in my opinion.
It would be way better to just let user know whenever there is an update. This would be a simple as adding an if clause to check if you have updated the version number on GitHub or spigot.
If you really wanne keep the up-to-date message around i would suggest putting it in console right after the plugin load!
Apart from that an amazing plugin, hope you will consider it.
The text was updated successfully, but these errors were encountered: