Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore teleport event for vehicle exit #7

Closed
CoolLord22 opened this issue Dec 7, 2022 · 3 comments · Fixed by #10
Closed

Ignore teleport event for vehicle exit #7

CoolLord22 opened this issue Dec 7, 2022 · 3 comments · Fixed by #10
Assignees
@CoolLord22
Labels
Enhancement New feature or request Resolved Issue/question has been addressed

Comments

@CoolLord22
Copy link
Owner

Leaving a vehicle (boat, minecart, and I think even rideable mobs) throws a teleport event and could incorrectly send entity failed teleport or entity left behind messages. Could add a check to just ignore if the teleport cause was a vehicle event.
@CoolLord22 CoolLord22 added the Enhancement New feature or request label Dec 7, 2022
@CoolLord22 CoolLord22 self-assigned this Dec 7, 2022
@CoolLord22
Copy link
Owner Author

@RhythmicSys Wanted to update you on this, I created a JIRA report for DISMOUNT not being seen as a teleport cause, and they did go ahead and patch it for 1.19.3! See below https://hub.spigotmc.org/jira/browse/SPIGOT-7204. So now, I should be able to ignore DISMOUNT (only on 1.19.3+ unfortunately)

@RhythmicSys
Copy link

Oh nice :D

@CoolLord22 CoolLord22 mentioned this issue Dec 25, 2022
Closed
@CoolLord22 CoolLord22 added the Resolved Issue/question has been addressed label Dec 28, 2022
@CoolLord22
Copy link
Owner Author

Pending push from my main PC, issue should be fixed in next patch.

CoolLord22 added a commit that referenced this issue Feb 1, 2023
@CoolLord22
Adding config flag for unknown teleport causes
6483295 
In versions below 1.19.3, leaving a vehicle triggered an unknown teleport cause. If you are on versions below 1.19.3, setting this config value to FALSE should help catch this issue and remove the unnecessary player notification about an entity being left behind. In versions greater than 1.19.3, a DISMOUNT cause was added due to this report. This config value can safely be ignored on versions >= 1.19.3. Fixes #7
@CoolLord22 CoolLord22 mentioned this issue Feb 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CoolLord22 CoolLord22

Labels
Enhancement New feature or request Resolved Issue/question has been addressed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release 2.2 CoolLord22/OtherAnimalTeleport
2 participants
@CoolLord22 @RhythmicSys