Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF97 Error in CoolProp Wrapping for SMath #1249

Closed
Novice77 opened this issue Oct 2, 2016 · 8 comments
Closed

IF97 Error in CoolProp Wrapping for SMath #1249

Novice77 opened this issue Oct 2, 2016 · 8 comments
Milestone
v6.2.0

Comments

@Novice77
Copy link

Novice77 commented Oct 2, 2016

Thank you for IF97 implementation of CoolProp efforts.
I've tested IF97 function of CoolProp in SMath.
Please, refer to attached test file for the results.

Thank you

M.S. Lee
IF97_question.pdf
@mikekaganski
Copy link
Contributor

Well... thank you for sharing your results.

@henningjp
Copy link
Contributor

The saturation props are implemented directly in IF97, but don't pass through yet to the CoolProp interface. I've started on coding and plan on implementing it soon.

@ibell
Copy link
Contributor

ibell commented Oct 3, 2016

Perhaps @Novice77 could help you?

@Novice77
Copy link
Author

Novice77 commented Oct 3, 2016

Very Sorry!
I'm a novice for programming, but I could test and share the results.

@henningjp
Copy link
Contributor

@Novice77 Saturation properties have been implemented (today) in the IF97 Backend. Those functions should be working now in your SMath wrapper. Give the dev version a day or so to update before you try it. Let us know.

Viscosity and Thermal Conductivity not yet implemented in IF97 or the Backend. They are on the list.

  • Saturation Properties (PQ and QT Inputs)
  • IF97 (IAPWS) Viscosity
  • IF97 (IAPWS) Thermal Conductivity

dcprojects pushed a commit to dcprojects/CoolProp that referenced this issue Nov 29, 2016
Added test file
8b49e40 
IF97 test file from CoolProp/CoolProp issue CoolProp#1249
dcprojects added a commit to dcprojects/CoolProp that referenced this issue Dec 1, 2016
@dcprojects
Added test file
e5405ec 
IF97 test file from CoolProp/CoolProp issue CoolProp#1249
ibell pushed a commit that referenced this issue Dec 2, 2016
@dcprojects @ibell
SMath Wrapper refactoring (#1365)
b371b75 
* Full update to latest SS 0.98 APIs

- SS: switched to LowLevelEvaluationFast interface;
- SS: fixed compiler warnings for deprecated methods/properties;
- refactoring;

* refactoring

- removed not useful try/catch from unit manager;
- refactoring of not used methods;

* Fix for SMath bug SS-2414

* minor changes

* Added folder for Test files

* Added test file

IF97 test file from CoolProp/CoolProp issue #1249

* changed filename

* added script for batch testing

* Review of dynamic assistant tootltip

* New layout for README.md

* Updated README.md

* Updated README.md

* Fixed combined emphasis in README.md
@henningjp henningjp mentioned this issue Dec 23, 2016
Closed
3 tasks
@henningjp henningjp mentioned this issue Jan 21, 2017
Merged
2 tasks
@henningjp
Copy link
Contributor

P.R. #1397 addresses this issue. Verification document attached as PDF.

NOTE: Attached IF97 test document shows that function CoolProp_saturation_ancillary() will not accept ANY backend strings, even HEOS.

IF97 Resolved.pdf

@henningjp
Copy link
Contributor

I messed up the syntax in PR #1397. This issue can be closed.

@henningjp
Copy link
Contributor

@ibell , @Novice77 Bump. I think this issue can be closed.

@ibell ibell added this to the MinorRelease milestone Feb 9, 2017
@ibell ibell closed this as completed Feb 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v6.2.0
Development

No branches or pull requests
4 participants
@mikekaganski @ibell @henningjp @Novice77