-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated compile.sh with cmake build of coolprop libray #1568
base: master
Are you sure you want to change the base?
Conversation
This Script build the CoolProp sources into a shared library, then compile the fluent udf into shared objects and finally it links the udf shared objects with the CoolProp shared library into the libudf.so
|
||
#CoolProp root source file (where CMakelist.txt is) --> adapt the following line | ||
CoolProp_sources_repository="/usersCFD/epd/ah33666/CoolProp-6.1.0" | ||
#Python 2.7 is mandatory to use cmake, by default on our machines the Python version is 2.4 --> adapt the following line |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really, any modern version of python can be used, including 3.x
cd $HOME | ||
|
||
#CoolProp root source file (where CMakelist.txt is) --> adapt the following line | ||
CoolProp_sources_repository="/usersCFD/epd/ah33666/CoolProp-6.1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be read in from an environment variable or passed as a command line argument rather than being hard coded. Can you please change that?
mkdir CoolProp_Build | ||
cd CoolProp_Build | ||
#uncomment following line for make file generation if python version <2.7 | ||
cmake -G "Unix Makefiles" -DCOOLPROP_EXTERNC_LIBRARY:BOOL="ON" -DCOOLPROP_SHARED_LIBRARY:BOOL="ON" -DPYTHON_EXECUTABLE:FILEPATH=$PYTHON_273 $CoolProp_sources_repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand what is going on here. It should work just fine with any non-ancient version of python
This Script build the CoolProp sources into a shared library, then compile the fluent udf into shared objects and finally it links the udf shared objects with the CoolProp shared library into the libudf.so