Angular 8+ es2015 support (qrcode rewrite) #53
Comments
|
Do you accept contributions for parts of the workload once you have a good plan for v2? |
|
@lukengda support is always welcome, I keep you (and any other interested) updated |
|
Any update on this? Would really love to set my target back to es2015. |
|
Since we are on that topic: |
|
@Cordobo This is still happening in Angular 8 |
|
@bmesin The workaround still needs to be applied. |
|
Having the same issue: Uncaught TypeError: Cannot read property '_android' of undefined |
|
@garysb Please use my workaround from above |
|
Hi, is it fixed? I tried to add it in a project where I cannot change the lib to es5 and as you mentioned, the workaround is probably needed to fix the "_android undefined" error. |
|
Waiting ... . Any planned release date for v 2.0.0? |
|
Not willing to add stress for you but going back to es5 brought me into trouble elsewhere. I like your solution and I'm waiting for a solution or production work-around in es2015... Cheers |
|
@egodefroy I came up with another workaround in the lib itself. I give it a try this weekend and I hope I can ship a new pre-2 version with es2015 support. |
|
Does the latest beta version contain this fix? |
|
Any news ? I would also like to use the package but I can't turn to ES5 |
No, the latest beta is more of a WIP and shouldn't be used (it'll break your build) |
|
@Cordobo thank you for maintaining this package. And for using https://github.com/soldair/node-qrcode in your rewrite. Appreciate your effort! Thank you! |
It has been already more than 30 days. Can you give us a status update please? |
|
All I want for Christmas is .... for this fix to be made available .... 🎄 |
Sorry, I couldn't make that wish come true... But, as of today, there is a working 2.0.0-alpha.1 published to npm (see my update above). Please do not expect too much, it does not break, it displays QR codes (as expected), but the API is not feature complete and there are no Docs available yet. |
|
Tada, Version 2.0.0 is out - thank my wife and my newborn son :) |
Angular defaults to the newer compile target `es2015`. The dependency angularx-qrcode is currently not supporting this compile target. Therefore we revert to target `es5`. Development regarding this issue is tracked here: Cordobo/angularx-qrcode#53 Once v2 is released we must switch back to es2015 builds to ensure latest and greates optimizations can be used by angular.
Hi there,
I open this issue to keep you updated about my ongoing efforts to provide es2015 support for Angular 8+.
Angular 8 changed the default target in tsconfig.json from es5 to es2015, which resulted in a build error when building with ng build (ng serve works as expected).
To follow the efforts, subscribe to this issue, I will update it from time to time.
Update 3: 29/12/2019 (29. Dec. 2019)
Version 2.0.0 is now available
Version 2.0.0 is now available for download and fixes the es5 issue in Angular 8+. A workaround is no longer needed.
TODOS:
Update 2: 29/12/2019 (29. Dec. 2019)
I finished the transition to the new qrcode library and released a series of 2.0 alpha versions to npm. The code is still WIP, the API is not feature complete and there are a couple of breaking changes due to the underlying lib.
Update 1: 09/02/2019 (2. Sep. 2019)
I'm now working in my spare time for a while on a recursion error in the lib. I push my branch to github when this issue is fixed.
Workaround (no longer needed)
A temporary workaround is to set the target in your tsconfig.json from es2015 to es5:
"target": "es5"The text was updated successfully, but these errors were encountered: