ConvoKit data_directory configuration setting for corpora not aligned between configuration and download functions

[seanzhangkx8]

In configuration file, there is a field data_directory which allows users to specify where they store the corpora. However, when users download the data using ConvoKit's download function, the corpus will always be downloaded to the default directory ~/.convokit/downloads, despite any configuration settings users made. That is because the data_directory configuration setting never gets accessed in download. It would be good to have them aligned in some way so all corpora are organized nicely together.

Code

Please refer to util.py and convokitConfig.py for detail.

Steps to reproduce

Try change data_directory configuration setting by
vim ~/.convokit/config.yml

Then, try download a corpus that is not already in your local directory, for example:
from convokit import Corpus, download
corpus = Corpus(filename=download("friends-corpus"))

See that the corpus is still getting downloaded to ~/.convokit/downloads instead of the specified data directory in configuration.

[seanzhangkx8]

Files to look into:
convokitConfig.py for configuration settings
util.py for the download function.

The issue is that the download function is not accessing convokitConfig, which always download corpus to default location ~/.convokit instead of user specified directory in ~/.convokit/config.yml.

fix should happen to have download function access convokitConfig which acess user specified location so getting correct download directory.