-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make "NA" string configurable #16
Comments
If you can give a some hint about how you think this should be implemented, I can work on it. I see no straightforward way. |
Honestly the clean solution to me seems to be using Java null, and in XML a non value, such as
|
Other than that, patches I can imagine:
|
As you've suggested, there's another way to look at this problem. Configuring the NA value is just a hack. The real issue is that the "not-applicable-ness" of a VarValueDef is a distinct property, different from its "name". But Tcases confuses things by encoding them together. A better solution would be to represent these 2 properties distinctly, both in the code for VarValueDef/VarBinding and in the XML representation of a SystemTestDef. |
I think it's important for the XML to make "not-applicable-ness" explicit and visible. In the code, it could be represented by a null value. But assuming that NA-ness and value are encoded separately, it would be just as well (and more backward-compatible) to keep using "NA". |
Actually a test variable value of "null" and "not applicable" might both be different interesting cases. So having a global NA type and allowing null as a value might also be interesting. For changes to the XML, you would have to decide how to handle backwards compatibility if you are considering making changes. A complex approach would be to start versioning the xml schema and supporting multiple versions (e.g. schema1.0 uses |
Fixed by PR #31 |
To avoid conflicts in system domains where "NA" has a different meaning.
The text was updated successfully, but these errors were encountered: