Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow non-English words in identifiers #30

Closed
kerrykimbrough opened this issue Jun 30, 2018 · 4 comments
Closed

Allow non-English words in identifiers #30

kerrykimbrough opened this issue Jun 30, 2018 · 4 comments

Comments

@kerrykimbrough
Copy link
Contributor

It should be possible to use non-English words as identifiers in all components of a SystemInputDef

@kerrykimbrough
Copy link
Contributor Author

For Tcases, an "identifier" is intended to be a sequence of one or more words or numbers, separated by either hyphen or underscore. Currently defined by the regex [A-Za-z0-9_-]+. I'm thinking of changing this to [\p{isAlphabetic}\p{isDigit}_-]+. But I'm not sure how well this works for Japanese and Chinese character sets. @tkruse, any advice?

@tkruse
Copy link
Contributor

tkruse commented Jul 1, 2018

@tkruse
Copy link
Contributor

tkruse commented Jul 1, 2018

Though for System name and function name, maybe the concept of a name is different from that of an identifier. What makes an identifier special to me is that it can be evaluated in expressions (such as boolean expressions or method invocations etc.). For properties and even variable names, it seems acceptable that they might need to be processed in other larger expressions. So they need identifiers not just names.

@kerrykimbrough
Copy link
Contributor Author

Fixed by PR #32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants