Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Implementing AI Hospitals #1361

Closed
wants to merge 1 commit into from

Conversation

mugmuggy
Copy link
Contributor

@mugmuggy mugmuggy commented Mar 3, 2018

I mentioned this branch in #967 but thought I would include it here for some more visibility, whilst I fine tune some more aspects. Happy to receive any comments but I do intend to update and tweak until I'm satisfied and make it RFC.

@altiereslima
Copy link
Contributor

Works fine

@mugmuggy
Copy link
Contributor Author

To be honest I haven't looked at it much since raising the PR, which was more as I reminder for me to revisit it. I was going to push it again with a series of smaller commits, addressing particular aspects also so I can comment functions and more accurately comment some of the code.

Most of my testing has just been in the first year also at one difficulty setting, so if you played it a bit more than that and across a couple of levels, it would be nice to know how that compares to the original.

@Alberth289346
Copy link
Contributor

Nice!
I think you should start by taking unrelated (like annual report), and somewhat related (refactoring existing hospital/etc code) changes out of this, and make them their own small PRs.

That way, you improve the existing code, and pave the way for adding the AI hospital.

@mugmuggy
Copy link
Contributor Author

That was the plan originally, I think I started putting some comments on some existing issues as well for that plan to be realised. Just if you had the other changes missing the corrupted annual report screen wouldn't make for a nice comparison for demonstration purposes and tuning the spawn logic was also done for comparison sake here.

@lewri lewri linked an issue Jul 23, 2020 that may be closed by this pull request
@lewri lewri added this to In progress in 1.0 Goal via automation Jul 23, 2020
@lewri
Copy link
Member

lewri commented Jan 30, 2021

@mugmuggy wondering how the state of play is with this now? Alberth laid down new player hospital and ai hospital foundations, so imagine some things would need moving about here too.

@lewri
Copy link
Member

lewri commented Jan 29, 2024

Unlinked from issue for now. Closing PR until mugmuggy's return or another adopter wishes to take this over (activity idle for near 6 years).

@lewri lewri closed this Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants