Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert parameterless new method is defined #342

Closed
Tracked by #98
jawoznia opened this issue Apr 4, 2024 · 0 comments · Fixed by #343
Closed
Tracked by #98

Assert parameterless new method is defined #342

jawoznia opened this issue Apr 4, 2024 · 0 comments · Fixed by #343
Assignees
@jawoznia
Labels
part Part of a bigger issue

Comments

@jawoznia
Copy link
Collaborator

jawoznia commented Apr 4, 2024 •
edited

new method is required for sylvia to dispatch message payload to proper contract method.
It most likely should never accept any parameters as those would have to be received in an entry point which has fixed input.
@jawoznia jawoznia mentioned this issue Apr 4, 2024
Open
4 tasks
@jawoznia jawoznia self-assigned this Apr 4, 2024
@jawoznia jawoznia added the part Part of a bigger issue label Apr 4, 2024
jawoznia added a commit that referenced this issue Apr 4, 2024
@jawoznia
feat: Assert new method defined (#342)
be4ec3d
@jawoznia jawoznia mentioned this issue Apr 4, 2024
Merged
jawoznia added a commit that referenced this issue Apr 8, 2024
@jawoznia
feat: Assert new method defined (#342)
c2467a4
jawoznia added a commit that referenced this issue Apr 8, 2024
@jawoznia
feat: Assert new method defined (#342)
ece1444
jawoznia added a commit that referenced this issue Apr 9, 2024
@jawoznia
feat: Assert new method defined (#342)
87ef246
@github-actions github-actions bot mentioned this issue Apr 9, 2024
Merged
kulikthebird pushed a commit that referenced this issue Apr 16, 2024
@github-actions
chore: release (#340)
b4bd4b4 
## 🤖 New release
* `sylvia`: 1.0.0 -> 1.0.1 (✓ API compatible changes)
* `sylvia-derive`: 1.0.0 -> 1.0.1

<details><summary><i><b>Changelog</b></i></summary><p>

## `sylvia-derive`
<blockquote>

##
[1.0.1](sylvia-derive-v1.0.0...sylvia-derive-v1.0.1)
- 2024-04-15

### Added
- Assert `new` method defined
([#342](#342))

### Fixed
- Add missing `map_err` on `IntoResponse` result

### Other
- Improve error message in `sv::custom` attribute
([#348](#348))
- Improve errors in `sv::messages` attribute
([#345](#345))
- Improve `no instantiation` error message
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jawoznia jawoznia

Labels
part Part of a bigger issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Assert new method defined (#342) CosmWasm/sylvia
1 participant
@jawoznia