PR1021 polished - do not merge #1037
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Alexander Peters <alpe@users.noreply.github.com>
Co-authored-by: Alexander Peters <alpe@users.noreply.github.com>
* main: Bump actions/checkout from 3.0.2 to 3.1.0 Revert module version to 1 as there is no migration Doc ante handler Fix: typos
Codecov Report
@@ Coverage Diff @@
## main #1037 +/- ##
==========================================
- Coverage 59.68% 59.61% -0.07%
==========================================
Files 52 53 +1
Lines 6590 6678 +88
==========================================
+ Hits 3933 3981 +48
- Misses 2370 2405 +35
- Partials 287 292 +5
|
|
|
|
I've merged this PR into 1021. It's ready to go. |
|
@alpe tysm |
|
Obsolete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1021 with minor updates, main branch merged and module version fixed
@vuong177 There were only some minor things left to do so I prepared them to speed up the process. (see my last commits). Unfortunately, I can not do a PR into yours here as it is on a fork repo. Can you merge them into your branch so that we get that into main? Alternatively we can use this one but as you started the work, it is nice to complete it.