Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix buffer in link layer write #1

Open
cospan opened this issue Mar 7, 2015 · 1 comment
Open

Fix buffer in link layer write #1

cospan opened this issue Mar 7, 2015 · 1 comment
Labels

Comments

@cospan
Copy link
Contributor

cospan commented Mar 7, 2015

After exercising this core on an FPGA we observed that the back pressure from the hard drives revealed some data loss on the link layer. A work around was implemented, it was a small buffer that would absorb the data transients. This is ugly and hacky and needs to be fixed correctly.

The area in the '/nysa-sata/rtl/link/sata_link_layer_read.v' can be found on line 228 and is related to these registers:

assign              d0_buf                    = bump_buffer[0];                                                                         |            if (data_scrambler_en) begin                                                                                                
assign              d1_buf                    = bump_buffer[1];                                                                         |              prev_data   <=  descr_dout;                                                                                               
assign              d2_buf                    = bump_buffer[2];                                                                         |            end                                                                                                                         
assign              d3_buf                    = bump_buffer[3]; 

The first milestone should be to expose the bugs in a consistent way.

@cospan cospan added the bug label Mar 7, 2015
@straycat95
Copy link

I find it too ,but how to fix it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants