Gitpodify Couchers wrap up

[darrenvong]

Taking over and wrapping up #1749. Added some instructions on using Gitpod in the frontend readme as another option for getting started!

Thanks @pawlean for introducing this to us in the first place :D

Open and test this at: https://gitpod.io/#https://github.com/Couchers-org/couchers/tree/backend/feature/gitpod-test

N/A on checklists, since no code changes to either frontend nor backend

[aapeliv]

Is there really no way to do this without the local companion app? The whole point of gitpodify would be to be able to run it in their VM and have a completely standardized environment with no local setup needed.

(Also, that link is 404-ing.)

[darrenvong]

Unless there is a way to workaround the fact cookies aren't being set properly when it comes from 8888-xxx.gitpod.io to 3000-xxx.gitpod.io... I don't think so. Maybe setting COOKIE_DOMAIN to gitpod.io in the backend environment variable? But that's part of the docker compose so I don't know how we can override that without changing that too, or make a Gitpod copy of docker-compose.

[darrenvong]

(Also, that link is 404-ing.)

The Gitpod badge link? It works for me (takes you to a login page, but should be fine once logged in with GitHub)

[aapeliv]

Maybe setting COOKIE_DOMAIN to gitpod.io in the backend environment variable?

That should be pretty straightforward, I think.

(Also, that link is 404-ing.)

The Gitpod badge link? It works for me (takes you to a login page, but should be fine once logged in with GitHub)

This link was failing: https://www.gitpod.io/blog/local-app. Either it was down very briefly (it's back up now), or they're doing some odd stuff with SSR and it defaults to a 404! I was getting that on all docs pages for a sec.

[darrenvong]

That should be pretty straightforward, I think.

Can it be done without creating another docker-compose and .env file though? Also I think the media stuff will still be broken, but that's broken locally anyway so maybe less of a big deal

[aapeliv]

Yeah I think you can just add env vars before the docker-compose command.

[aapeliv]

No, actually; that probably won't work. Sorry, I misunderstood something.

I think we can create an override docker-compose file though. Something like docker-compose.gitpod.yml which only contains the overrides; then you can do something like docker-compose -f docker-compose.yml -f docker-compose.gitpod.yml ... and it should override the stuff specified in the latter file: https://docs.docker.com/compose/extends/#multiple-compose-files

[darrenvong]

That extra docker-compose.gitpod.yml override did the trick and fixed the cookies issue! 🚀 So now it's all working within the browser:

https://gitpod.io/#https://github.com/Couchers-org/couchers/tree/backend/feature/gitpod-test

I've also updated the README and removed the reference to the companion app, so now it is really all on in the browser!

[aapeliv]

Getting very nitpicky... sorry!

[aapeliv]

Just tried running this. It's looking good!

A few more things that I noticed:

• Map isn't loading because the dev key isn't set to allow .gitpod.io: I'll see if I can fix this one up
• In the same way you set COOKIE_DOMAIN, you should set BASE_URL to gp url 3000, so that e.g. signup links point to the right place. This might be a tad more tricky :/

[aapeliv]

Map isn't loading because the dev key isn't set to allow .gitpod.io: I'll see if I can fix this one up

Tried to fix this

[darrenvong]

Map isn't loading because the dev key isn't set to allow .gitpod.io: I'll see if I can fix this one up

Tried to fix this

Is that a setting in some couchers mapbox account? Any luck?

In the same way you set COOKIE_DOMAIN, you should set BASE_URL to gp url 3000, so that e.g. signup links point to the right place. This might be a tad more tricky :/

Yeah I think that might be difficult without some command to substitute in the value into the file itself before spinning the Docker containers up, but then people might end up accidentally committing those changes so I'm not sure that's a good idea :/ lol maybe the companion app is still the easiest way due to how finicky our setup is / Gitpod's domains are too dynamic

[aapeliv]

In the same way you set COOKIE_DOMAIN, you should set BASE_URL to gp url 3000, so that e.g. signup links point to the right place. This might be a tad more tricky :/

Yeah I think that might be difficult without some command to substitute in the value into the file itself before spinning the Docker containers up, but then people might end up accidentally committing those changes so I'm not sure that's a good idea :/ lol maybe the companion app is still the easiest way due to how finicky our setup is / Gitpod's domains are too dynamic

I think if you add to the gitpod override docker compose file like this

version: "3"
services:
  backend:
    environment:
      - BASE_URL

with no value, then I think you should be able to pass BASE_URL from the command line, by doing BASE_URL=$(gp url 3000) docker-compose ....

https://docs.docker.com/compose/environment-variables/#pass-environment-variables-to-containers

[aapeliv]

@darrenvong could you review please? (You made the pr so can't ask for review through gh)

[darrenvong]

Just tried with my latest tweaks and this looks good to me! Can't approve it as I originally opened the PR 😅

[lucaslcode]

Works for me :)

addressed