Show events from user communities on dashboard #2026
Conversation
darrenvong
added
1.topic backend
| .where(ClusterSubscription.user_id == context.user_id) | ||
| .where(Cluster.is_official_cluster) | ||
| .order_by(Node.id) | ||
| .limit(100000) |
There was a problem hiding this comment.
I kinda copied this from threads.py where 100000 is an arbitrarily "large enough" (?) number/page size cap so it should be sufficient to include all communities the user is in one page, but not unbounded
There was a problem hiding this comment.
Whenever we convert this into a subquery, the list of clusters will not be extracted from the database and this arbitrary limit will go away. So it is fine for now :)
darrenvong
changed the title
It's because of this - https://gitlab.com/gitlab-com/gl-infra/production/-/issues/5590 😠 apparently the adjacent |
Otherwise, users can barely any details of the time without most of it being cropped off
The button loads more events on page rather than taking user to the all events page based on PR comment
darrenvong
force-pushed
the
web/feature/events-from-user-communities
branch
from
ee7edd0
to
a6e2a91
Compare
| ).not.toBeInTheDocument(); | ||
|
|
||
| // Simulates scrolling horizontally to the end | ||
| mockIsIntersecting(screen.getByRole("progressbar"), true); |
| fetchNext={isBelowSm ? fetchNextPage : undefined} | ||
| hasMore={hasNextPage} | ||
| isFetching={isFetching} |
There was a problem hiding this comment.
Wow, I totally forgot I put this functionality in :D
There was a problem hiding this comment.
Indeed, made my job very easy 😉
aapeliv
added
release notes: done
…er-communities Show events from user communities on dashboard
Probably my first time getting my hands dirty on the backend a little bit on this project, so hopefully I haven't done anything too terrible :p it was too inefficient and annoying me to have to send one request per community just to find out which events are in the communities the user is in, so I extended the
ListMyEventsrpc to include events from the user's communities by default as well.Desktop
Mobile
Closes #1880
Backend checklist
autoflake -r -i --remove-all-unused-imports src && isort . && black .inapp/backenddevelopif necessary for linear migration historyWeb frontend checklist
yarn format && yarn lint --fixyarn lint