Skip to content

Commit

Permalink
Fix duplicate hamburger button
Browse files Browse the repository at this point in the history
Keep ignoring app/themes but include app/theme/default
Remove sidebar collapsed button from topbar
Add sidebar collapsed button to user row
Make user-sidebar flex
  • Loading branch information
trangmei committed Sep 10, 2018
1 parent 5cfb74d commit 0290ebd
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 8 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@

# Ignore additional themes
/app/themes/*
!/app/themes/default/*

# Ignore public download/upload folders
/public/downloads/*
Expand Down
1 change: 1 addition & 0 deletions app/assets/stylesheets/course/layout.scss
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@
@include text-overflow;
font-size: 18px;
font-weight: bold;
flex: 1;
}

.image,
Expand Down
7 changes: 0 additions & 7 deletions app/themes/default/views/layouts/_topbar.html.slim
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,6 @@ nav.navbar.navbar-inverse.navbar-fixed-top role="navigation"
span.icon-bar
span.icon-bar
span.icon-bar
- if sidebar?
button.navbar-toggle.collapsed type="button" data-toggle="collapse" data-target=".sidebar" aria-expanded="false" aria-controls="navbar"
span.sr-only
= t('layout.navbar.toggle_sidebar')
span.icon-bar
span.icon-bar
span.icon-bar
a.navbar-brand href=root_path
= t('layout.coursemology')
div.collapse.navbar-collapse#site-navigation-navbar
Expand Down
2 changes: 2 additions & 0 deletions app/views/layouts/course.html.slim
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
div.col-xs-12.user
= display_user_image(current_user)
span#user-sidebar = link_to_user(current_course_user || current_user)
button.btn.btn-default.navbar-toggle.collapsed.pull-right type="button" data-toggle="collapse" data-target="#course-navigation-sidebar" aria-expanded="false" aria-controls="navbar"
span.glyphicon.glyphicon-menu-hamburger
- if current_course_user.student? && current_course.gamified?
= display_course_user_badge(current_course_user)
nav.navbar-default role='navigation'
Expand Down
1 change: 0 additions & 1 deletion config/locales/en/layout.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ en:
layout:
coursemology: 'Coursemology'
navbar:
toggle_sidebar: 'Toggle Sidebar'
toggle_navigation: 'Toggle Navigation'
courses: 'Courses'
all_courses: 'All Courses'
Expand Down

0 comments on commit 0290ebd

Please sign in to comment.