Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade frontend dependencies #2772

Merged

Conversation

jeremyyap
Copy link
Member

@jeremyyap jeremyyap commented Jan 18, 2018

Left with Jest 22. Modifying window.location.pathname with Object.defineProperty no longer works due to jsdom having been upgraded to 11.

https://github.com/facebook/jest/blob/master/CHANGELOG.md
jestjs/jest#5124

Other breaking changes:

Also, we can consider upgrading to Babel 7.
https://medium.com/@jdolle/babel-7-beta-instructions-aed5cf17048b

@ghost ghost assigned jeremyyap Jan 18, 2018
@ghost ghost added the Needs Review label Jan 18, 2018
@kxmbrian
Copy link
Contributor

redux-form, react-player, css-loader and expose-loader just made new releases in the past couple of days. Should we also upgrade style-loader and react-dropzone?

Didn't see any breaking changes indicated on those. Maybe can update and then we can merge this first, then do jest in a separate PR?

Would prefer to wait for Babel to move out of beta, but don't think it's a problem to move now also.

@jeremyyap
Copy link
Member Author

style-loader and react-dropzone versions have been updated in yarn.lock. Is there a specific command I should be using such that the versions in package.json would be updated as well?

@kxmbrian
Copy link
Contributor

Referring to this, can try yarn upgrade --latest or yarn upgrade-interactive --latest. You'll have to revert yarn.lock first though.

@kxmbrian kxmbrian merged commit 758bd75 into Coursemology:master Jan 22, 2018
@ghost ghost removed the Needs Review label Jan 22, 2018
@kxmbrian
Copy link
Contributor

Thanks @jeremyyap!

@jeremyyap jeremyyap deleted the jeremyyap/upgrade-frontend branch January 24, 2018 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants