Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote beta branch #264

Merged
merged 47 commits into from
Feb 25, 2019
Merged

Promote beta branch #264

merged 47 commits into from
Feb 25, 2019

Conversation

leventeliu
Copy link
Contributor

Promote beta branch to develop.

leventeliu and others added 30 commits January 28, 2019 19:29
Since all needed fields are exported, just use its literal notation.
Which allows the genesis block to be included by a normal function
call.
Add blocks cache limit for block producers
@leventeliu leventeliu changed the title Feature/promote beta Promote beta branch Feb 25, 2019
@codecov
Copy link

codecov bot commented Feb 25, 2019

Codecov Report

Merging #264 into develop will decrease coverage by 0.5%.
The diff coverage is 83.51%.

@@             Coverage Diff             @@
##           develop     #264      +/-   ##
===========================================
- Coverage    80.93%   80.43%   -0.51%     
===========================================
  Files          159      158       -1     
  Lines        11877    11905      +28     
===========================================
- Hits          9613     9576      -37     
- Misses        1577     1627      +50     
- Partials       687      702      +15

@codecov
Copy link

codecov bot commented Feb 25, 2019

Codecov Report

Merging #264 into develop will decrease coverage by 0.29%.
The diff coverage is 83.51%.

@@            Coverage Diff             @@
##           develop     #264     +/-   ##
==========================================
- Coverage    80.74%   80.45%   -0.3%     
==========================================
  Files          159      158      -1     
  Lines        11877    11905     +28     
==========================================
- Hits          9590     9578     -12     
- Misses        1599     1626     +27     
- Partials       688      701     +13

Copy link
Contributor

@xq262144 xq262144 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

Copy link
Contributor

@auxten auxten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@auxten auxten merged commit cc7ca59 into develop Feb 25, 2019
@laodouya laodouya deleted the feature/promote_beta branch February 25, 2019 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants