Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull css minification away form the standard sass task #6

Closed
rob-bar opened this issue Dec 10, 2015 · 0 comments · Fixed by #12
Closed

Pull css minification away form the standard sass task #6

rob-bar opened this issue Dec 10, 2015 · 0 comments · Fixed by #12

Comments

@rob-bar
Copy link
Contributor

rob-bar commented Dec 10, 2015

The sass task now minifies the css .pipe(mincss())
but this should be bundled in the improve task and made separate.

It is more consistent,
and it can be easier to inspect the plain css code to spot errors.
If you do want the css to be expanded you can just run gulp compile (the grouped task without the improve this will expand the css).

There can also be a difference in output css on dev/stage and prod.
Easier to debug and view the raw css files when bugs appear.

I know sourcemapping got us covered, but there are edge cases where you do want to look at the compiled css expanded. Debuggers like the ie9 debugger do not cover sourcemapping, I see an advantage there as well. Do not get me wrong, the standard gulp task will still minify the css, but it will be done in another separated step. Maybe we'll lose some milliseconds, but that is a minor issue since we win on flexibility.

@rob-bar rob-bar added this to the 0.1.0 milestone Dec 10, 2015
@rob-bar rob-bar self-assigned this Dec 10, 2015
rob-bar added a commit that referenced this issue Dec 17, 2015
cdooms added a commit that referenced this issue Dec 23, 2015
cdooms added a commit that referenced this issue Dec 23, 2015
rob-bar added a commit that referenced this issue Dec 23, 2015
rob-bar added a commit that referenced this issue Dec 23, 2015
* 'issue-6' of github.com:Crosscheck/jacket:
  issue #6: added semicolon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant