Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for v1.0 #364

Closed
The-EDev opened this issue Mar 18, 2022 · 0 comments · Fixed by #372
Closed

Update documentation for v1.0 #364

The-EDev opened this issue Mar 18, 2022 · 0 comments · Fixed by #372
Labels
task Non code related issue

Comments

@The-EDev
Copy link
Member

The-EDev commented Mar 18, 2022

Existing Guides

  • App

    • No mention of run_async()
    • Some App methods don't have doc
  • Logging

    • "creating a custom logger" lacks "introduced in"
  • JSON

    • Note or warning regarding nan or inf needed
  • Templating

    • No mention of set_base() or set_global_base()
    • No mention of returning mustache via lambda
    • No mention of sanitization
  • Multipart

    • Needs to be rewritten to accomodate part and header maps
  • Middleware

    • Needs inspection
  • Static Files

    • No mention of sanitization

From PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Non code related issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant