Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Make signal handler optional #85

Merged
merged 1 commit into from
Dec 20, 2020
Merged

[fix] Make signal handler optional #85

merged 1 commit into from
Dec 20, 2020

Conversation

NRizzoInc
Copy link
Contributor

  • follow up from [fix] Make signal handler optional ipkn/crow#390
  • crow app has a built in signal handler which may interfere with another signal handler
  • solution: add ability to remove crow's handlers, and to add them back
    • to remove: app.signal_clear().port().multithreaded().run()
    • to add back: app.signal_add(int signal_number)
  • credit: @ilejn (I just put up a pr for his suggested patch)

@NRizzoInc NRizzoInc mentioned this pull request Dec 19, 2020
Closed
The-EDev
The-EDev approved these changes Dec 20, 2020
View reviewed changes
Copy link
Member

@The-EDev The-EDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems alright. Thanks again for the contribution

@The-EDev The-EDev merged commit 28ef0a9 into CrowCpp:master Dec 20, 2020
@The-EDev The-EDev mentioned this pull request Dec 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@The-EDev The-EDev The-EDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NRizzoInc @The-EDev