-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support versioned index and improve name search #1378
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….dev into bugfix/searchFullName
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
🤖 Generated by Copilot at e5a06fb
This pull request improves the OpenSearch indexing process for the search_sync_worker service. It adds a function to trim long strings to avoid indexing errors, updates the types and settings for the indexes, and uses versioned indexes and aliases for each document type. It also adds new scripts to the package.json file for testing and debugging the indexing process. The changes affect the files
activity.sync.service.ts
,member.sync.service.ts
,opensearch.service.ts
,types.ts
,package.json
, andbyteLength.ts
.
🤖 Generated by Copilot at e5a06fb
Why
How
🤖 Generated by Copilot at e5a06fb
trimUtf8ToMaxByteLength
to common library to truncate strings that exceed OpenSearch byte limit (link)trimUtf8ToMaxByteLength
to trim string attributes of activity and member documents before indexing them (link, link, link, link, link, link)package.json
for running OpenSearch indexing tasks (link)IndexVersions
to types file to store version numbers for each index name (link)analyzer
to prefixedMapping object to specify custom analyzer for lowercasing keywords (link)OPENSEARCH_INDEX_SETTINGS
to types file to define settings for each index name (link)Checklist ✅
Feature
,Improvement
, orBug
.