-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Production performance #1380
Merged
Merged
Production performance #1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themarolt
added
Bug
Created by Linear-GitHub Sync
Improvement
Created by Linear-GitHub Sync
labels
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
🤖 Generated by Copilot at 3286eff
This pull request contains various changes to improve the performance, logging, debugging and data integrity of the backend and the data sink, integration data, integration run and integration stream workers. It reduces the database updates, removes unnecessary indexes, filters out deleted or irrelevant data, and adds conditions to avoid duplicate or redundant data. It also adds a new script to manually trigger the stream processed event for a run. It modifies several files, such as
webhookProcessor.ts
,activity.repo.ts
,integrationDataService.ts
,nodeWorkerSQS.ts
, and the migration files.
🤖 Generated by Copilot at 3286eff
Why
How
🤖 Generated by Copilot at 3286eff
activity.repo.ts
andincomingWebhookRepository.ts
to fix bugs and enforce data integrity (link, link, link)incomingWebhookRepository.ts
andwebhookProcessor.ts
to support different types of webhooks and avoid conflicts (link, link)dataSink.service.ts
,integrationDataService.ts
,integrationRunService.ts
andintegrationStreamService.ts
to reduce database updates and rely on stream processed event (link, link, link, link, link, link, link, link, link, link)member.repo.ts
,member.service.ts
andsettings.repo.ts
to exclude unchanged or empty columns and reduce query size (link, link, link, link)triggerResultProcessing
method inintegrationDataService.ts
to pass to data sink worker for logging and debugging (link, link, link)member.service.ts
to ensure consistency and avoid errors (link, link)integrationData.repo.ts
to reduce table size (link)package.json
inintegration_run_worker
to manually trigger stream processed event for debugging (link)webhookProcessor.ts
andnodeWorkerSQS.ts
to reduce noise and verbosity (link, link)queue/index.ts
to simplify queue settings (link)Checklist ✅
Feature
,Improvement
, orBug
.