Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/member organization filter should include dates c 2025 #1381

Merged

Conversation

themarolt
Copy link
Contributor

@themarolt themarolt commented Aug 26, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at f2723c2

This pull request improves the search functionality and performance by refactoring the opensearch schema and queries to use the nested type for fields that contain arrays of objects. It also fixes a bug in the member count for organizations and adds a filter for organizations in the member search. The changes affect the files organization.repo.ts, member.sync.service.ts, types.ts, members.ts, memberRepository.ts, and opensearch.ts.

🤖 Generated by Copilot at f2723c2

Opensearch changes
Nested fields and filters add
Spring cleaning for data

Why

How

🤖 Generated by Copilot at f2723c2

  • Add a filter for organizations in the MemberRepository class to enable searching for members by one or more organization ids and exclude inactive members (link)
  • Modify the SQL query in the OrganizationRepository class to count only active members in each organization and join with the memberOrganizations table (link, link, link)
  • Rename the properties for nested fields in the MemberSyncService class to reflect the new naming convention (link, link, link)
  • Update the index versions for the members, activities, and organizations opensearch indices to migrate to the new nested fields mapping (link)
  • Update the regex patterns for matching nested fields in the opensearch mapping to use the new naming convention (link, link)
  • Update the types of the identities, tags, and organizations fields in the MembersOpensearch class to use the nested type (link, link)
  • Add a new enum value NESTED to the OpensearchFieldType enum to support the nested type (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@themarolt themarolt added the Bug Created by Linear-GitHub Sync label Aug 26, 2023
@themarolt themarolt marked this pull request as ready for review August 26, 2023 10:27
@themarolt themarolt merged commit 1ffa250 into main Aug 26, 2023
9 checks passed
@themarolt themarolt deleted the bugfix/member-organization-filter-should-include-dates-C-2025 branch August 26, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant