Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display manually created organizations and members #1383

Merged
merged 4 commits into from
Aug 28, 2023

Conversation

yeganathan18
Copy link
Member

@yeganathan18 yeganathan18 commented Aug 27, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 3ca013a

This pull request adds a new manuallyCreated column to the organizations, members, and organizationCaches tables in the database, and updates the corresponding models, repositories, services, tests, and frontend components to handle this column. The manuallyCreated column indicates whether an organization or a member was created by a user or by the system, and helps to filter out irrelevant data for the search sync process. The pull request also includes migration scripts to add and drop the column, and a console log for debugging.

🤖 Generated by Copilot at 3ca013a

We are the manually created ones
We defy the system's tyranny
We mark our columns with our flags
We sync our data with our destiny

Why

How

🤖 Generated by Copilot at 3ca013a

  • Add manuallyCreated column to organizations, members, and organizationCaches tables in the public schema to track whether an entity was created manually by a user or automatically by the system (link,link)
  • Add manuallyCreated attribute to Organization, Member, and OrganizationCache models in the backend to map the table columns to the TypeScript objects (link,link,link)
  • Add manuallyCreated column to the list of columns to select in the OrganizationRepository, MemberRepository, and OrganizationCacheRepository classes in the backend to query the database and return the entity objects (link,link,link)
  • Modify the filter object in the OrganizationRepository class in the backend to include the manuallyCreated column in the condition to filter the organizations based on whether they are manually created or have activity count greater than zero (link)
  • Add a console log statement in the OrganizationRepository class in the backend to print the parsed organization query for debugging purposes (link)
  • Add manuallyCreated property to the data object in the OrganizationFormPage and MemberFormPage components in the frontend to set the manuallyCreated flag to true when creating a new entity from the form (link,link)
  • Add manuallyCreated attribute to the IDbOrganizationSyncData and IDbMemberSyncData interfaces in the search sync worker to define the shape of the entity data to be synced with the search engine (link,link)
  • Add manuallyCreated column to the list of columns to select in the OrganizationRepository and MemberRepository classes in the search sync worker to query the database and return the entity data to be synced with the search engine (link,link)
  • Remove the inner join between the members and activity_data tables in the MemberRepository class in the search sync worker to simplify the query and avoid unnecessary joins that are not relevant for the sync process (link)
  • Modify the where clause in the MemberRepository class in the search sync worker to include the manuallyCreated column in the condition to filter the members based on whether they are manually created or have activity data to be synced with the search engine (link)
  • Add manuallyCreated property to the member and organization objects in the InitService class in the search sync worker to create mock entities to initialize the sync process (link,link)
  • Assign the manuallyCreated attribute to the p.bool_manuallyCreated property in the MemberSyncService and OrganizationSyncService classes in the search sync worker to map the entity data to the search engine document format (link,link)
  • Add manuallyCreated property to the mock entity objects in the backend and search sync worker tests to test the new column and attribute (link,link,link,link,link,link,link,link,link,link)
  • Add and remove the import statement for the storeToRefs function from the pinia library in the MemberFormPage component in the frontend, likely by mistake or leftover from a previous change (link,link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@yeganathan18 yeganathan18 added the Improvement Created by Linear-GitHub Sync label Aug 27, 2023
@yeganathan18
Copy link
Member Author

Fixes C-2103 & C-2144

@yeganathan18 yeganathan18 changed the title Show manually created organization and member in list Display manually created organization and member in list Aug 27, 2023
@yeganathan18 yeganathan18 force-pushed the improvement/manually-created branch 2 times, most recently from e28da46 to d483f99 Compare August 28, 2023 04:47
@yeganathan18 yeganathan18 changed the title Display manually created organization and member in list Display manually created organizations and members Aug 28, 2023
@yeganathan18 yeganathan18 merged commit 23f2bd8 into main Aug 28, 2023
10 checks passed
@yeganathan18 yeganathan18 deleted the improvement/manually-created branch August 28, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants