-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C-2161 - Optimize handling of segments activity channels #1384
Merged
themarolt
merged 19 commits into
main
from
feature/c-2161-optimize-handling-of-segmentsactivitychannels
Sep 4, 2023
Merged
C-2161 - Optimize handling of segments activity channels #1384
themarolt
merged 19 commits into
main
from
feature/c-2161-optimize-handling-of-segmentsactivitychannels
Sep 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ze-handling-of-segmentsactivitychannels
…ze-handling-of-segmentsactivitychannels
…ze-handling-of-segmentsactivitychannels
…ze-handling-of-segmentsactivitychannels
…ze-handling-of-segmentsactivitychannels
…ze-handling-of-segmentsactivitychannels
themarolt
approved these changes
Sep 4, 2023
themarolt
deleted the
feature/c-2161-optimize-handling-of-segmentsactivitychannels
branch
September 4, 2023 10:06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
🤖 Generated by Copilot at 9a47210
This pull request introduces a new table
segmentActivityChannels
to store the activity channels data for the segments, which are groups of users who share common characteristics or behaviors. It also updates theSegmentRepository
and thesettings.repo
classes to use the new table instead of theactivityChannels
column in thesegments
table. Additionally, it provides the migration scripts to create and drop the new table and to transfer the existing data.
🤖 Generated by Copilot at 9a47210
Why
How
🤖 Generated by Copilot at 9a47210
segmentActivityChannels
table to store the relation between segments and their activity channels (link)segmentActivityChannels
table in undo migration script (link)segments
table intosegmentActivityChannels
table using JSONB query (link)activityChannels
column fromsegments
table update logic insegmentRepository.ts
(link, link)segmentActivityChannels
table insegmentRepository.ts
update method usingON CONFLICT DO NOTHING
query (link)segmentActivityChannels
table and selectplatform
andchannel
columns insegmentRepository.ts
getSubprojects method (link)activityChannels
property of each segment with platform-channel object insegmentRepository.ts
getSubprojects method (link)segmentActivityChannels
table insettings.repo.ts
updateSegmentActivityChannels method usingON CONFLICT DO NOTHING
query (link)activityChannels
column update logic fromsettings.repo.ts
updateSegmentActivityChannels method (link)Checklist ✅
Feature
,Improvement
, orBug
.