don't use deduplication id for streamProcessed events #1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrrikkotua
approved these changes
Aug 28, 2023
themarolt
deleted the
bugfix/trigger-integration-stream-processed-checks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
🤖 Generated by Copilot at fff85c4
Simplified the
streamProcessedmethod of theIntegrationRunWorkerEmitterclass by removing an unnecessary parameter from thesendMessagemethod. This change affects the fileservices/libs/sqs/src/instances/integrationRunWorker.ts.
🤖 Generated by Copilot at fff85c4
Why
How
🤖 Generated by Copilot at fff85c4
sendMessagemethod call by removing redundant parameter (link)Checklist ✅
Feature,Improvement, orBug.Add screehshots to the PR description for relevant FE changesNew backend functionality has been unit-tested.API documentation has been updated (if necessary) (see docs on API documentation).