Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix organizations enrichment issues #1394

Merged
merged 4 commits into from
Aug 30, 2023
Merged

Conversation

joanagmaia
Copy link
Contributor

@joanagmaia joanagmaia commented Aug 30, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 12a4f78

Refactored and simplified the revenue range field in the organization form component. Used a computed option and helper functions to handle different formats and units for displaying revenue ranges. Removed unused code and imports.

🤖 Generated by Copilot at 12a4f78

Sing, O Muse, of the skillful coder who refined
The form and logic of the revenue range field,
And by his cunning mind and nimble fingers designed
A simpler and more elegant solution to wield.

Why

How

🤖 Generated by Copilot at 12a4f78

  • Simplify and refactor the revenue range field for the organization form (link, link, link, link)
  • Use a single el-option component with a computed value and label from the revenueRange module in organization-form-details.vue (link)
  • Remove the unused revenueRangesOptions array and import the default export of the revenueRange module instead in organization-form-details.vue (link)
  • Define two helper functions getValue and getMiddle to format the revenue range value and separator in revenueRange.ts (link)
  • Update the displayValue function to use the helper functions and handle the empty object case in revenueRange.ts (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@joanagmaia joanagmaia added the Bug Created by Linear-GitHub Sync label Aug 30, 2023
@joanagmaia joanagmaia self-assigned this Aug 30, 2023
@joanagmaia joanagmaia changed the title Fix revenueRange display Fix organizations enrichment issues Aug 30, 2023
Copy link
Member

@yeganathan18 yeganathan18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joanagmaia looks good to me!

@yeganathan18 yeganathan18 merged commit 62cd1d9 into main Aug 30, 2023
10 checks passed
@yeganathan18 yeganathan18 deleted the bugfix/organizations-enrichment branch August 30, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants