Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of nested fields in OpenSearch query #1407

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

yeganathan18
Copy link
Member

@yeganathan18 yeganathan18 commented Sep 1, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at a240668

Added support for nested field queries in Opensearch. Modified FieldTranslator and OpensearchQueryParser classes to detect and handle nested fields in the filters object.

🤖 Generated by Copilot at a240668

Nested query added
To filter crowd fields with depth
Autumn leaves nested

Why

How

🤖 Generated by Copilot at a240668

  • Add support for nested field queries in Opensearch (link, link)
  • Create a new method isNestedField in fieldTranslator.ts to check if a field name starts with nested_ (link)
  • Modify parseCrowdFilters in opensearchQueryParser.ts to wrap the query condition for nested fields in a nested query with the correct path and query (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@yeganathan18 yeganathan18 added the Bug Created by Linear-GitHub Sync label Sep 1, 2023
@yeganathan18 yeganathan18 self-assigned this Sep 1, 2023
@yeganathan18 yeganathan18 merged commit a3399a2 into main Sep 1, 2023
9 checks passed
@yeganathan18 yeganathan18 deleted the bugfix/identities branch September 1, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants