Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C-2200 - Init tracing with OpenTelemetry #1408

Merged
merged 32 commits into from
Oct 12, 2023
Merged

C-2200 - Init tracing with OpenTelemetry #1408

merged 32 commits into from
Oct 12, 2023

Conversation

loicsaintroch
Copy link
Member

@loicsaintroch loicsaintroch commented Sep 1, 2023 •
edited by ghost

Changes proposed ✍️

What

🤖 Generated by Copilot at e19e7ca

This pull request adds a new tracing library to the services/libs folder. The library provides a function to create and manage service tracers using OpenTelemetry. The library also includes configuration files for TypeScript, ESLint, and Prettier.
​

🤖 Generated by Copilot at e19e7ca

tracing library
adds TypeScript linting, formatting
autumn code cleanup

Why

How

🤖 Generated by Copilot at e19e7ca

  • Add tracing library for creating and managing service tracers (F1-F7)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@loicsaintroch loicsaintroch self-assigned this Sep 1, 2023
@sausage-todd
Copy link
Contributor

Looks good, but shall we maybe add some usage example somewhere? To kinda start with at least one trace already

@sausage-todd
Copy link
Contributor

Looks good apart from a couple comments. Congrats on finishing it!

@loicsaintroch
Copy link
Member Author

Latest changes allow automatic instrumentation and correlation in workers, with a parent span ProcessMessage on each message received to link each span to a common parent trace. Example:

Screenshot 2023-09-26 at 09 58 20 (2)

themarolt
themarolt reviewed Oct 9, 2023
View reviewed changes
services/libs/tracing/src/tracer.ts
attrs[SemanticResourceAttributes.K8S_POD_NAME] = process.env['HOSTNAME']
}

sdk = new NodeSDK({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we pass OTEL URL and other configuration options here? I would prefer to have it explicit vs. some AWS autoconfiguration happening in the SDK.

@loicsaintroch loicsaintroch merged commit bd2b22f into main Oct 12, 2023
8 checks passed
@loicsaintroch loicsaintroch deleted the feature/c-2200-create-foundations-of-the-internal-library branch October 12, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themarolt themarolt themarolt approved these changes

@sausage-todd sausage-todd Awaiting requested review from sausage-todd

Assignees

@loicsaintroch loicsaintroch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@loicsaintroch @sausage-todd @themarolt