Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/separate service for webhooks c 927 #1409

Merged
merged 6 commits into from
Sep 1, 2023

Conversation

themarolt
Copy link
Contributor

@themarolt themarolt commented Sep 1, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 96362b6

This pull request adds, updates and fixes several workflows and services related to the webhook-api service. It enables automated and selective deployment of the service to different environments using GitHub Actions. It also adds docker files and scripts for building and running the service locally. It fixes some bugs in the database and redis connection functions in other services by adding await keywords. It also updates the module option in the tsconfig.json files of some services to use native ES modules.

🤖 Generated by Copilot at 96362b6

We're building and deploying the webhook-api
To test it in the staging and production sea
We're fixing the bugs and improving the code
So pull on the rope and sing with me

Why

How

🤖 Generated by Copilot at 96362b6

  • Add input parameter to choose whether to deploy webhook-api service in production and LF production workflows (link, link)
  • Add jobs to build and push webhook-api docker image and deploy webhook-api service to cluster in production and LF production workflows (link, link, link, link)
  • Add workflows to deploy webhook-api service to staging and LF staging environments on push events to relevant branches (link, link)
  • Comment out github webhook handler route in webhook-api service (link)
  • Add shell script, dockerfile and dockerignore for building webhook-api docker image (link, link, link)
  • Add docker-compose file for running webhook-api service locally (link)
  • Fix missing await keywords for database and redis connection functions in data_sink_worker, integration_data_worker, integration_run_worker and integration_stream_worker services (link, link, link, link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@themarolt themarolt added the Improvement Created by Linear-GitHub Sync label Sep 1, 2023
@themarolt themarolt merged commit 39a9070 into main Sep 1, 2023
8 checks passed
@themarolt themarolt deleted the enhancement/separate-service-for-webhooks-C-927 branch September 1, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants