Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix creation of parent and grandparent segment documents for members/orgs #1443

Merged

Conversation

themarolt
Copy link
Contributor

@themarolt themarolt commented Sep 7, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at b2d9d7a

This pull request fixes bugs and improves code quality in the files that handle the organization and member data for the search index. It enhances the SQL queries in organizationRepository.ts to classify and match organizations correctly. It also simplifies the indexing logic and reduces redundancy in organization.sync.service.ts and member.sync.service.ts.

🤖 Generated by Copilot at b2d9d7a

sync code refactored
bugs fixed in organization
autumn of cleaning

Why

How

🤖 Generated by Copilot at b2d9d7a

  • Fix bugs in SQL queries for organization level and segment level in organizationRepository.ts (link, link)
  • Refactor code for aggregating and prefixing member and organization data for search index in member.sync.service.ts and organization.sync.service.ts (link, link)
  • Add comment to explain indexing logic for organization data in organization.sync.service.ts (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@themarolt themarolt added the Bug Created by Linear-GitHub Sync label Sep 7, 2023
@themarolt themarolt merged commit f2ea9df into main Sep 7, 2023
9 checks passed
@themarolt themarolt deleted the bugfix/organization-member-indexing-for-segments-C-2025 branch September 7, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants