Improve locks and upserts in data-sink-worker

[garrrikkotua]

Changes proposed ✍️

What

🤖 Generated by Copilot at fcf1da3

This pull request refactors and optimizes the data sink worker service, which handles the processing of organization, member, and activity data. It simplifies the queries and updates of the organization and member repositories, improves the performance and correctness of the member and activity services, and adds a new common function for array comparison. It also removes some unused or redundant code related to the segmentId field, which was part of a removed feature.
​

🤖 Generated by Copilot at fcf1da3

We are the masters of the code, we make it fast and clean
We purge the useless segments, we find the members by their name
We use the common functions, we loop through the fields of change
We are the rebels of the data, we crush the bugs with rage

Why

How

🤖 Generated by Copilot at fcf1da3

• Simplify queries and lock keys by removing segmentId condition and parameter (link, link, link)
• Refactor update methods and updateCache method of OrganizationService class to use loops instead of multiple if statements or assignments (link, link, link, link)
• Move addToSegment call from if branch to else branch in updateMember method of MemberService class to avoid redundant calls (link)
• Add length check to member emails array before comparing it with dbMember emails array in updateMember method of MemberService class to avoid unnecessary comparisons and updates (link)
• Replace areArraysEqual function with firstArrayContainsSecondArray function in import statement of MemberService class to use the new utility function from common library (link, link)
• Remove displayName variable and conditional assignment from createOrUpdate method of OrganizationService class to simplify code and avoid unnecessary variables (link)

Checklist ✅

• Label appropriately with Feature, Improvement, or Bug.
• Add screehshots to the PR description for relevant FE changes
• New backend functionality has been unit-tested.
• API documentation has been updated (if necessary) (see docs on API documentation).
• Quality standards are met.

[epipav]

included one comment