Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't throw errors when Discord channel is not found #1470

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

garrrikkotua
Copy link
Contributor

@garrrikkotua garrrikkotua commented Sep 12, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 5554438

This pull request fixes a bug in the Discord integration that caused errors when fetching deleted or inaccessible messages during webhook processing. It adds error handling and null checks to getMessage.ts and processWebhookStream.ts to gracefully skip such messages.

🤖 Generated by Copilot at 5554438

Unknown Channel error
Discord message may be null
Skip it in the fall

Why

How

🤖 Generated by Copilot at 5554438

  • Handle Unknown Channel error when fetching Discord messages (link)
  • Skip parsing null messages in webhook processing (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@garrrikkotua garrrikkotua merged commit f08a660 into main Sep 12, 2023
9 checks passed
@garrrikkotua garrrikkotua deleted the fix/handle-discord-webhooks-non-existing-channel branch September 12, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants