Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved slack notifications #1492

Merged
merged 7 commits into from
Sep 15, 2023
Merged

Conversation

gaspergrom
Copy link
Contributor

@gaspergrom gaspergrom commented Sep 14, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at ca22d91

This pull request enhances the Slack notifications for new activities and new members by using a new utility to generate profile URLs from @crowd/types. It also improves the code formatting and readability in organizationRepository.ts and platforms.ts.

🤖 Generated by Copilot at ca22d91

The code review had some nice changes
To format and refactor the ranges
The Slack messages got
Some profile links and a lot
Of details and buttons for exchanges

Why

How

🤖 Generated by Copilot at ca22d91

  • Format code to use multiple lines for ternary operators in organizationRepository.ts (link)
  • Import integrationProfileUrl utility from @crowd/types to generate profile URLs for different platforms in newActivityBlocks.ts and newMemberBlocks.ts (link, link)
  • Update member properties and profiles arrays with more information and emojis in newActivityBlocks.ts and newMemberBlocks.ts (link, link, link)
  • Simplify and enhance Slack message blocks for new activity and new member events by removing unnecessary headers and attachments, adding avatars and buttons, and using overflow menus for additional profiles in newActivityBlocks.ts and newMemberBlocks.ts (link, link, link, link, link)
  • Add integrationProfileUrl object to platforms.ts to handle profile URL generation for different platforms (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@gaspergrom gaspergrom added the Improvement Created by Linear-GitHub Sync label Sep 14, 2023
@gaspergrom gaspergrom self-assigned this Sep 14, 2023
@gaspergrom gaspergrom removed the request for review from epipav September 15, 2023 07:02
@gaspergrom gaspergrom merged commit aa5cb7e into main Sep 15, 2023
8 checks passed
@gaspergrom gaspergrom deleted the improvement/slack-notifications branch September 15, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants