Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

organization.findById performance improvements #1499

Merged
merged 3 commits into from
Sep 14, 2023

Conversation

epipav
Copy link
Collaborator

@epipav epipav commented Sep 14, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 269d02b

Fixed bugs in the organizationRepository that affected the accuracy of organization statistics. Improved the query logic and performance by using appropriate columns and joins.

🤖 Generated by Copilot at 269d02b

The member_data subquery had some bugs
That messed up the counts of activities and mugs
So they changed the columns and joins
To filter out the noise
And now the results are more accurate and snug

Why

How

🤖 Generated by Copilot at 269d02b

  • Fix member count and activity count logic in member_data subquery of getOrganizationById function (link, link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@epipav epipav marked this pull request as ready for review September 14, 2023 12:28
@epipav epipav self-assigned this Sep 14, 2023
@epipav epipav added the Bug Created by Linear-GitHub Sync label Sep 14, 2023
@epipav epipav merged commit 7301636 into main Sep 14, 2023
8 checks passed
@epipav epipav deleted the bugfix/organization-performance-fixes branch September 14, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants