Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove member org enrichment that was using clearbit. #1504

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

themarolt
Copy link
Contributor

@themarolt themarolt commented Sep 15, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 3ed9e66

Removed deprecated code related to enrich_member_organizations service from various files in the backend and data sink worker. Changed the way node worker messages are sent to the FIFO queue to avoid conflicts.

🤖 Generated by Copilot at 3ed9e66

No more conflicts in the queue, we use the timestamp
EnrichMemberOrganizationsQueueMessage is gone, we don't need that crap
We purge the deprecated code, we clean the worker factory
We rebel against the old way, we enrich with a new strategy

Why

How

🤖 Generated by Copilot at 3ed9e66

  • Removed enrichMemberOrganizations service and related types and imports as it was deprecated and replaced by a different mechanism for enriching member organizations (link, link, link, link, link, link, link, link, link, link)
  • Deleted backend/src/serverless/microservices/nodejs/bulk-enrichment/enrichMemberOrganizationsWorker.ts as it was no longer needed (link)
  • Changed MessageGroupId and MessageDeduplicationId parameters for sending node worker messages to use the current timestamp instead of the tenant ID in backend/src/serverless/utils/nodeWorkerSQS.ts to avoid potential conflicts and errors with the FIFO queue (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@themarolt themarolt added Bug Created by Linear-GitHub Sync Improvement Created by Linear-GitHub Sync labels Sep 15, 2023
@themarolt themarolt merged commit 53bf734 into main Sep 15, 2023
9 checks passed
@themarolt themarolt deleted the hotfix/remove-member-org-enrichment-with-clearbit branch September 15, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync Improvement Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants