Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking primary key maps in while creating/updating in hubspot #1512

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

epipav
Copy link
Collaborator

@epipav epipav commented Sep 18, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at cd4b3f1

This pull request fixes a bug in the hubspot integration that could overwrite the email and domain fields of hubspot members and companies. It adds conditions to check if the hubspot field is not equal to email or domain before mapping the crowd field to the hubspot property. It applies this fix to both the batch create and batch update functions for members and organizations.

🤖 Generated by Copilot at cd4b3f1

hubspot mapping
avoid overwriting fields
autumn leaves falling

Why

How

🤖 Generated by Copilot at cd4b3f1

  • Prevent overwriting email and domain fields in hubspot integration (link, link, link, link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@epipav epipav self-assigned this Sep 18, 2023
@epipav epipav added the Bug Created by Linear-GitHub Sync label Sep 18, 2023
@epipav epipav marked this pull request as ready for review September 18, 2023 09:46
@epipav epipav merged commit b567dfc into main Sep 18, 2023
9 checks passed
@epipav epipav deleted the bugfix/hubspot-prevent-primary-key-override branch September 18, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants