Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New organization attributes in list, filters and hubspot automations #1519

Merged
merged 4 commits into from
Sep 28, 2023

Conversation

joanagmaia
Copy link
Contributor

@joanagmaia joanagmaia commented Sep 19, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at db3ee5d

Added and updated various filters and components for the organization module to support Hubspot integration. The changes allow users to filter and view organizations based on Hubspot properties and tags, such as revenue, employee growth, and churn. The changes also improve the display and validation of number filters and inputs, and the Hubspot property map component. The changes affect files in frontend/src/modules/organization, frontend/src/modules/automation, frontend/src/integrations/hubspot, and frontend/src/shared/modules/filters.

🤖 Generated by Copilot at db3ee5d

Sing, O Muse, of the mighty pull request
That brought new filters and columns to the list
Of organizations, rich in Hubspot data,
And made the labels clearer and more accurate.

Why

How

🤖 Generated by Copilot at db3ee5d

  • Add four new columns to the organization list table to display Hubspot properties (link, link)
  • Add four new filters to the organization filters object to filter by Hubspot properties (link, link)
  • Add a new filter to the organization filters object to filter by tags (link)
  • Create new filter config files for annualEmployeeChurnRate, annualEmployeeGrowthRate, employeeCount, and tags (link, link, link, link)
  • Modify the annualRevenue filter config to use a custom component and remove unused options (link, link)
  • Create a new component AnnualRevenueFilter for the annualRevenue filter (link)
  • Extend the NumberFilterOptions and NumberFilterValue interfaces with new properties (link, link)
  • Modify the numberApiFilterRenderer function to accept a parse function (link)
  • Modify the numberItemLabelRenderer function to accept a suffix option (link)
  • Modify the NumberFilter component to accept a suffix and validators prop (link, link, link, link)
  • Modify the FilterInput component to include slots for prefix and suffix (link, link)
  • Modify the getLabel function in hubspot-property-map.vue to handle '12Month' fields (link)
  • Simplify the template and remove the nestedKeyParser prop in organization-attributes-json-renderer.vue (link, link, link)
  • Remove the nested-key-parser attribute in organization-view-aside-enriched.vue (link)
  • Update the import paths for Hubspot related components and types in automation-types/hubspot/config.ts (link)
  • Update the import paths for filter related types in annualRevenue/config.ts and number.label.renderer.ts (link, link)
  • Remove the unused defineProps import in organization-list-table.vue (link)
  • Add a new computed property tagsColumnWidth in organization-list-table.vue to calculate the optimal width for the tags column (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@joanagmaia joanagmaia added the Feature Created by Linear-GitHub Sync label Sep 19, 2023
@joanagmaia joanagmaia self-assigned this Sep 19, 2023
@joanagmaia joanagmaia merged commit 1affaaa into main Sep 28, 2023
6 checks passed
@joanagmaia joanagmaia deleted the feature/organization-attributes-list-filter-hubspot branch September 28, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants