Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration bugfixes #1527

Merged
merged 9 commits into from
Sep 20, 2023
Merged

Integration bugfixes #1527

merged 9 commits into from
Sep 20, 2023

Conversation

themarolt
Copy link
Contributor

@themarolt themarolt commented Sep 20, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 4a1e6cc

This pull request improves the integration stream worker and script executor services by refactoring the Github integration library, updating the Dockerfile and package.json files, and enhancing the error handling and reliability of the SQS queue and database connection.

🤖 Generated by Copilot at 4a1e6cc

Sing, O Muse, of the mighty deeds of the integration stream workers
Who, with skill and cunning, forged new scripts and tokens for their tasks
And updated their package and Dockerfile, to ease their toils and troubles
And made their services more robust, to handle errors and timeouts

Why

How

🤖 Generated by Copilot at 4a1e6cc

  • Move and add ./services/scripts/build_libs.sh command in script executor Dockerfile to optimize caching and building (link, link)
  • Add new scripts for processing and triggering streams and webhooks in package.json for integration stream worker service (link)
  • Change processWebhookStream and processStream methods in integration stream service to return boolean values and handle errors (link, link, link)
  • Comment out query_timeout option in database library to avoid timeouts for long-running queries (link)
  • Simplify getGithubToken function and use it in processPullCommitsStream function in Github integration library to avoid token issues (link, link, link)
  • Use generateUUIDv1 function to generate unique message IDs for SQS queue in integration stream worker library (link, link, link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@themarolt themarolt added the Bug Created by Linear-GitHub Sync label Sep 20, 2023
@themarolt themarolt marked this pull request as ready for review September 20, 2023 10:54
@themarolt themarolt merged commit 9263603 into main Sep 20, 2023
8 checks passed
@themarolt themarolt deleted the bugfix/queue-deduplication-id-test branch September 20, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants