Synchronous stream processing in hubspot #1538
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
🤖 Generated by Copilot at 64cfd71
Refactored the Hubspot integration to use an enum type for the streams and handle multiple streams in the root stream data. This improves the code quality and enables mapping Hubspot entities to Crowd.dev entities.
🤖 Generated by Copilot at 64cfd71
Why
How
🤖 Generated by Copilot at 64cfd71
HubspotStream.ROOT
toHubspotStream
enum to identify the root stream (link)HubspotStream[]
to store the streams to be generated based on the settings and the entities ingenerateStreams.ts
(link)HubspotStream.MEMBERS
andHubspotStream.ORGANIZATIONS
to the streams array instead of publishing them directly ingenerateStreams.ts
(link, link)generateStreams.ts
(link)processRootStream
function inprocessStream.ts
to use the streams array as the data of the root stream (link)HubspotStream.MEMBERS
orHubspotStream.ORGANIZATIONS
and proceed with the corresponding mapping logic inprocessStream.ts
(link, link)processStream.ts
, as the streams array should only contain valid values from theHubspotStream
enum (link)Checklist ✅
Feature
,Improvement
, orBug
.