Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organization findById update in integration sync worker #1575

Merged
merged 4 commits into from
Sep 29, 2023

Conversation

epipav
Copy link
Collaborator

@epipav epipav commented Sep 28, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at ae38aa9

This pull request updates the integration sync worker service to filter organization data by segment. It changes the syncOrganization method in organization.sync.service.ts and the findOrganization method in organization.repo.ts to use the integration.segmentId as a filter and a payload parameter. This improves the query performance and the accuracy of the organization data synchronization.

🤖 Generated by Copilot at ae38aa9

To sync orgs from sources external
The worker must be more prudential
It uses segmentId
As a filter and guide
And calls findOrganization with potential

Why

How

🤖 Generated by Copilot at ae38aa9

  • Optimize and filter organization data query by segment id (link)
  • Pass segment id to organization repository methods in sync service (link, link, link)
  • Use segment id as part of organization update and create payloads in sync service (link, link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@epipav epipav marked this pull request as ready for review September 28, 2023 16:28
@epipav epipav self-assigned this Sep 28, 2023
@epipav epipav added the Bug Created by Linear-GitHub Sync label Sep 28, 2023
@epipav epipav merged commit 56a5a6c into main Sep 29, 2023
8 checks passed
@epipav epipav deleted the bugfix/integration-sync-organizations-query-update branch September 29, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants